[PATCH] Add stackframes to public libsmbclient functions

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Nov 28 06:50:27 GMT 2007

On Wed, Nov 28, 2007 at 03:37:12PM +1100, tridge at samba.org wrote:
> I know I'm coming into this debate a little late, but perhaps this
> helps?

That's indeed very clever, thanks. If I had seen this
proposal when I first added talloc_stackframe() I would
probably have removed the stackframe thing immediately.

On the other hand, talloc_tos() at least to me has proved to
be very handy and in particular very robust. We've had quite
a few memleaks due to temporary talloc contexts not being
freed in obscure error returns. This does not mean that I
intend to be sloppy, but it's a cozy feeling that things
can't go really bad.

I think Jeremy and Jerry should also comment here I think :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20071128/b569da14/attachment.bin

More information about the samba-technical mailing list