signed-off PATCH: Re: op-lock weirdness with winXP and ntvfs_cifs
azez at ufomechanic.net
Mon Nov 26 15:36:56 GMT 2007
Please would someone attend to this mild patch? It's over a month old
and the error is pretty obvious.
In the vfs_cifs backend, opened files are not added to the DLIST at
cvfs_private->files, so the list of open files was always empty.
This prevents oplock-break propagation among other things.
I guess there are implications for the test suite too, as far as oplock
tests, and tracking of open files? And closing non-existent files, I
guess file-close has been failing too (not finding the f).
Also, does cvfs_exit need to update this file list with closures?
We may want to review the DLIST_REMOVE use in cvfs_close in this patch,
I'm not sure if I should do it in the async callback instead of before.
I also don't know who should be free-ing the f and it's h, I suspect
they should be free'd here.
I haven't yet tracked down the ntvfs_handle creator for vfs_cifs, but a
cursory look suggests that the h is owned by the f, so free-ing the f
may be all that is required?
Signed-off-by: azez at ufomechanic.net
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1848 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20071126/c91e8891/file_dlist.bin
More information about the samba-technical