Failures in add_sockaddr_to_array()

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy,

I don't see how winbindd in v3-2-test could be working at all.
Looking at add_sockaddr_to_array(), we are not storing the port
information.  This is pretty perplexing.  So either no one
is testing this or else all the packets send to port 0 on my DC
are some configuration anomaly.


static bool add_sockaddr_to_array(TALLOC_CTX *mem_ctx,
	struct sockaddr_storage *pss, uint16 port,
        struct sockaddr_storage **addrs, int *num)
{
	*addrs = TALLOC_REALLOC_ARRAY(mem_ctx, *addrs,
		struct sockaddr_storage, (*num)+1);

        if (*addrs == NULL) {
                *num = 0;
                return False;
        }

        (*addrs)[*num] = *pss;
        *num += 1;
        return True;
}




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHRHDEIR7qMdg1EfYRAvOOAJ4qNwxWvm6mLuk+K14lsHc4241U0ACfViyF
PLLxOeSpwEuR7zqMG97C1T8=
=skfU
-----END PGP SIGNATURE-----