[PATCH] Add stackframes to public libsmbclient functions

Alexander Bokovoy ab at samba.org
Tue Nov 20 16:16:50 GMT 2007

Volker Lendecke пишет:
> On Tue, Nov 20, 2007 at 09:55:31AM +0300, Alexander Bokovoy wrote:
>>> Volker, I am ok with stackframe the only thing I don't digest yet
>>>  is the use of an implicit destructor (can be replaced in theory)
>>>  but samba3 code never uses destructors so I am ok with its use
>> DBWRAP code in Samba 3 uses destructors, see 
>> source/lib/dbwrap_tdb.c:db_tdb_record_destr(). It even allocates 
>> childs in destructor in relies on 'childs freed after calling 
>> destructor' semantics.
> If all of you are against this construct, why can't you comment on it
>  when I checked it in in the first place? Now it is going to be a 
> fucking hell lot of work to remove it all again!!
Now you put me in defending position. :-) I like this trick though I
made additional comments to it in my ctdb-merge branch after checking
through talloc code to make no surprises for anyone else in future.

Nothing against you and the code (who we are to be against? Code speaks!).

/ Alexander Bokovoy
Samba Team                      http://www.samba.org/
ALT Linux Team                  http://www.altlinux.org/
Midgard Project Ry              http://www.midgard-project.org/

More information about the samba-technical mailing list