[PATCH] Add stackframes to public libsmbclient functions

Jeremy Allison jra at samba.org
Mon Nov 19 18:44:51 GMT 2007

On Mon, Nov 19, 2007 at 10:31:16AM -0500, Derrell Lipman wrote:

> I don't have a strong opinion about that one way or the other.  If the
> exits are simple 'return some value' I have no problem with it.  If
> every return has to do a bunch of clean-up, I prefer a single exit
> point.

This is just a future patch :-).

> In this case, I'm not the original author of the code, so unless I've
> had reason to change it, I've just maintained the original
> organization of the code.  Even with a single entry and exit point,
> though, I'd still have a hard time justifying "magic" inputs to the
> lower-layer functions.  Without some strong reason to the contrary, I
> prefer the black-box concept with inputs and outputs well defined by
> parameters and return value.

This is how libsmbclient behaves to the upper layers,
and Volker's patch does the same :-).


More information about the samba-technical mailing list