[PATCH] Add stackframes to public libsmbclient functions
jra at samba.org
Mon Nov 19 18:04:43 GMT 2007
On Mon, Nov 19, 2007 at 10:50:43AM -0500, Derrell Lipman wrote:
> libsmbclient is a small part of Samba. If having libsmbclient
> allocate and free those stackframes really and truly helps the
> lower-layer functionality, I won't be stubborn about this. I'd sure
> rather, though, provide input towards what I feel would be a cleaner
Yes, it *really* *really* does help tidy things up. A lot.
I'm expecting Volker was joking about removing it (talloc_stackframe).
He'd better be :-) :-). I've started to depend on this idiom.
The best way to fix this is to (a) apply and maintain Volkers'
patch (which I haven't yet reviewed, but as it's Volker code
I'm willing to bet it's completely correct :-) :-), or (b)
refactor the libsmbclient exits to always exit via one place
with the talloc_destroy.
Volker has already done most of this work. I vote for (a).
I will help maintain this code. Either way it's a showstopper
for 3.2.0 that must be fixed before release.
More information about the samba-technical