[PATCH] Add stackframes to public libsmbclient functions
derrell.lipman at unwireduniverse.com
Mon Nov 19 15:38:37 GMT 2007
On Nov 19, 2007 10:37 AM, Volker Lendecke <Volker.Lendecke at sernet.de> wrote:
> On Mon, Nov 19, 2007 at 10:31:16AM -0500, Derrell Lipman wrote:
> > lower-layer functions. Without some strong reason to the contrary, I
> > prefer the black-box concept with inputs and outputs well defined by
> > parameters and return value.
> Can you please then provide some hints how to solve the
> DEBUG(10, ("sid: %s\n", sid_string_static(sid)));
> problem? sid_string_static using a static variable is much
> worse than passing a magic talloc ctx in my opinion. Or
> should we go back to using those?
I don't have any problem with providing a talloc context; I just don't
like it being "magic". If a context is needed, it should be passed as
a parameter, I think. Am I missing something, or do you just not like
the concept of passing it as a parameter?
More information about the samba-technical