[PATCH] Add stackframes to public libsmbclient functions

Derrell Lipman derrell.lipman at unwireduniverse.com
Mon Nov 19 15:32:23 GMT 2007


On Nov 19, 2007 10:24 AM, Volker Lendecke <Volker.Lendecke at sernet.de> wrote:
> On Mon, Nov 19, 2007 at 10:13:23AM -0500, Derrell Lipman wrote:
>
> > More importantly, I don't think that
> > one should need to think about the needs of the lower layer.  The
> > lower layer should be a black box with its inputs solely defined by
> > its parameters, not by a required pair of function calls pre- and
> > post-.
> >
> > I still think there's a way to make use of what you've done, but it'll
> > require more thought.
>
> If you see any way without C++ destructors, I'd be happy to
> see it. But before that we only have the option to remove
> talloc_stackframe() again if you insist on every function
> being completely isolated in this respect.

I looked at alloca() to see if it could be done using that, but the
documentation indicates that it's buggy in some implementations and
it's not a POSIX stand, so it's probably not a good way to go.

Derrell


More information about the samba-technical mailing list