svn commit: samba r25959 - in branches/SAMBA_4_0/source/lib/ldb/ldb_tdb: .

Andrew Bartlett abartlet at samba.org
Thu Nov 15 11:04:48 GMT 2007


On Thu, 2007-11-15 at 10:34 +0100, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> > +	
> > +	/* possibly initialise the baseinfo */
> > +	if (r == LDB_SUCCESS) {
> 
> this comment is wrong (cut-n-paste?)

Yeah, I've fixed that now, thanks!

> (check for null DNs)

> This is never reached as the first if also checks for this...

Thanks for spotting that.  As background, I had to swap the order
because too many things pass down 'NULL', and this is 'invalid' as a DN,
but was accepted previously. 

Thanks. 

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071115/9e0d7700/attachment.bin


More information about the samba-technical mailing list