[PATCH] Remove a static fstring

Volker Lendecke vl at sernet.de
Sun Nov 11 14:38:50 GMT 2007

I'm not sure why this used to be static, to me it seems that every time this
variable is overwritten. I just don't see how name_status_find() could return
true and not overwrite name. Can someone please review this and potentially
check it in?


 source/libsmb/cliconnect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index 2fdd122..f0b03a8 100644
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -1806,7 +1806,7 @@ struct cli_state *get_ipc_connect(char *server,
 struct cli_state *get_ipc_connect_master_ip(struct ip_service *mb_ip, pstring workgroup, struct user_auth_info *user_info)
 	char addr[INET6_ADDRSTRLEN];
-        static fstring name;
+        fstring name;
 	struct cli_state *cli;
 	struct sockaddr_storage server_ss;

More information about the samba-technical mailing list