Should find_builtin_domain() really panic on failure?

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Mair wrote:

> Rather than a panic, would it be appropriate for 
> find_builtin_domain() to just return the NULL to
> winbindd_gettoken_async() and let it do the same
> thing as it does when find_domain_from_sid_noinit() 
> fails, i.e. log a message and:

If you canot find the builtin winbindd_domain structure
something is very wrong.  The PANIC is correct here IMO.
Are you seeing a case where the BUILTIN domain is not available?





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHM9D9IR7qMdg1EfYRApH+AKCyctlqZBFx+yeB+rG65mXuvnpuFACg1G3Y
JRuuCZi5VIlIaQGbgLZ0y/M=
=cXt2
-----END PGP SIGNATURE-----