Remove NTSTATUS from NDR Layer
Stefan (metze) Metzmacher
metze at samba.org
Tue Nov 6 07:13:42 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
>> It passes make test and I think I have reviewed the diffs
>> carefully, but please check careful too.
> Looks good overall!
How should I commit this?
3 patches pidl/, librpc/ndr/ + all the callers?
> A general thought: ndr_map_error2ntstatus() should support more
> ndr_err_code values. That was already the case before your patch though,
> so I think it's ok if we fix that later.
> Some minor issues:
> I would prefer a "const char *ndr_errstring(enum ndr_err_code);"
> function over converting to NTSTATUS and then calling ndr_errstr() on
> that each time.
Yes, but can be the next patch.
> The name RAP_GOTO() is unclear imho - something like RAP_CHECK() or
> RAP_CHECK_GOTO() would be clearer.
> NDR_GOTO() and NDR_RETURN() are present in more than one C file - I'd
> rather see them in torture/ndr/ndr.h.
The rap code needs sharing between torture/rap/ and ntvfs/ipc/
in general, so I just leave it to have the same code twice
as I don't want to think about the real solution as it would be
unrelated to my scope.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical