tdb_chainlock_with_timeout_internal error

Stefan (metze) Metzmacher metze at samba.org
Tue Nov 6 06:19:47 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jeremy,

some minor comments below.

> ------------------------------------------------------------------------
> 
> diff --git a/source/lib/replace/libreplace.m4 b/source/lib/replace/libreplace.m4
> index e9b19b7..1fdd778 100644
> --- a/source/lib/replace/libreplace.m4
> +++ b/source/lib/replace/libreplace.m4
> @@ -94,7 +94,7 @@ fi
>  
>  
>  AC_CHECK_HEADERS(sys/syslog.h syslog.h)
> -AC_CHECK_HEADERS(sys/time.h time.h)
> +AC_CHECK_HEADERS(sys/time.h time.h signal.h)

this isn't needed signal.h is available on all systems.

>  AC_CHECK_HEADERS(stdarg.h vararg.h)
>  AC_CHECK_HEADERS(sys/socket.h netinet/in.h netdb.h arpa/inet.h)
>  AC_CHECK_HEADERS(netinet/ip.h netinet/tcp.h netinet/in_systm.h netinet/in_ip.h)
> diff --git a/source/lib/replace/replace.h b/source/lib/replace/replace.h
> index b96356a..d5aaf1a 100644
> --- a/source/lib/replace/replace.h
> +++ b/source/lib/replace/replace.h
> @@ -79,6 +79,20 @@
>  #include <stddef.h>
>  #endif
>  
> +#ifdef HAVE_SIGNAL_H
> +#include <signal.h>
> +#endif
> +
> +#if defined(HAVE_VOLATILE)
> +#define VOLATILE volatile
> +#else
> +#define VOLATILE
> +#endif

libreplace should better provide the lower
case 'volatile' is it's not available simular to
'inline'

> +#if !defined(HAVE_SIG_ATOMIC_T_TYPE)
> +typedef int sig_atomic_t;
> +#endif
> +

this belongs to lib/replace/system/wait.h

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHMAeCm70gjA5TCD8RAjYLAJ9Ox4ASasYSmoILMAzcDyv5X9OGjQCeO+C+
7htLvuF1Q91lmYOpRtJey5Y=
=FQQr
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list