Code duplication is bad :/

[Volker Lendecke]

On Tue, May 29, 2007 at 08:10:23AM -0400, simo wrote:
> The problem is the use of winbindd_idmap.tdb from smbd.
> If we change something in the future we may forget again there is
> pdb_tdb.c that expects something there.You should have used passdb.tdb
> IMO.

See my other mail: It was there when I made the
transformation, and I did not want to change the on-disk
format.

> By moving everything to a common function at least we keep all access to
> the same tdb in one place so future changes will less likely break
> something.

Then get the access routines into something in lib/ and have
pdb_tdb and winbind both use those. Or change the on-disk
format.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070529/096f8886/attachment.bin