Code duplication is bad :/

Gerald (Jerry) Carter jerry at samba.org
Tue May 29 12:11:28 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> On Tue, May 29, 2007 at 06:31:40AM -0500, Gerald (Jerry) Carter wrote:
>>> I just found that we open winbindd_idmap.tdb 
>>> independently in tdbsam_new_rid() in pdb_tdb.c
>>> With the new idmap code which can have different 
>>> providers for the allocation backend this is
>>> probably wrong.
>> Shouldn't the RID counter passdb.tdb?
> 
> Sure, in theory this is the right place. But at the time I
> pulled the RID allocator from winbind I did not want to
> break the on-disk data format.

ok.  Gotcha.  I'll have to go back and look at the code again.





jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGXBhvIR7qMdg1EfYRAgutAJ9lYnfsCWmW4H4iBZ7G8SeUV9b2nQCeNZKl
Cc55CVcI+40hIvMw9j01sao=
=i2tX
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list