adding support for inet_pton and inet_ntop to lib/replace

Stefan (metze) Metzmacher metze at samba.org
Thu May 24 12:48:37 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Adam schrieb:
> On Thu, May 24, 2007 at 02:10:22PM +0200, Stefan (metze) Metzmacher wrote:
>> Michael Adam schrieb:
>>> Index: lib/replace/replace.h
>>> ===================================================================
>>> --- lib/replace/replace.h	(revision 23108)
>>> +++ lib/replace/replace.h	(working copy)
>>> @@ -74,6 +74,10 @@
>>>  #include <sys/types.h>
>>>  #endif
>>>  
>>> +#ifdef HAVE_SYS_SOCKET_H
>>> +#include <sys/socket.h>
>>> +#endif
>>> +
>> Hi Michael,
>>
>> I'm not sure this is correct here...
>>
>> I would better include "system/network.h" in the inet_*.c files
> 
> Oh yes, I was not aware of that - sounds reasonable.
> 
> Updated patch is attached.

looks good, please commit this to all branches:-)

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFGVYmlm70gjA5TCD8RAtyYAJ4qNnBXFZ8Ifng1LBqRPEhtdAc2SwCfbDXL
dVdooS9qiAI3O5c8uNHxT5U=
=WCIB
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list