svn commit: samba r23072 - in branches/SAMBA_3_0/source/nsswitch: .

[Guenther Deschner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Michael,

obnox at samba.org wrote:
> +/* If you are looking for "dn_lookup": Yes, it used to be here!
> + * It has gone now since it was a major speed bottleneck in
> + * lookup_groupmem (its only use). It has been replaced by
> + * an rpc lookup sids call... R.I.P. */

nice comment :-)


> -		if (lookup_cached_sid(mem_ctx, &sid, &domain_name, &name, &name_type)) {
> -
> -			DEBUG(10,("ads: lookup_groupmem: got sid %s from cache\n", 
> -				sid_string_static(&sid)));
> -
> -			(*names)[*num_names] = CONST_DISCARD(char *,name);
> -			(*name_types)[*num_names] = name_type;
> -			sid_copy(&(*sid_mem)[*num_names], &sid);
> -

Hm, what was the reason the remove the frontend cache for lookups that
we already have done and go out to the network with every query?

Guenther

- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGUw3mSOk3aI7hFogRAt5mAJ99MQ+6XUMFYKZIk2MkYNnnEBbBsQCeOcWp
r67jleG9HfS/EGCQFDkuPKs=
=+CJb
-----END PGP SIGNATURE-----