Suspicious && ?

[Jeremy Allison]

On Sun, May 20, 2007 at 12:20:18AM +0200, Volker Lendecke wrote:
> Hi, Jeremy!
> 
> reply.c:2648 looks a bit funny, or at least it needs a
> comment. Or the attached patch is right....
> 
> Volker

> Index: smbd/reply.c
> ===================================================================
> --- smbd/reply.c	(Revision 23014)
> +++ smbd/reply.c	(Arbeitskopie)
> @@ -2645,7 +2645,7 @@
>  
>    normal_read:
>  
> -	if ((smb_maxcnt && 0xFF0000) > 0x10000) {
> +	if ((smb_maxcnt & 0xFF0000) > 0x10000) {
>  		int sendlen = setup_readX_header(inbuf,outbuf,smb_maxcnt) - smb_maxcnt;
>  		/* Send out the header. */
>  		if (write_data(smbd_server_fd(),outbuf,sendlen) != sendlen) {

Yes, you're correct - thanks. Stupid typo strikes again :-).

Thanks,

	Jeremy