Janitorial tasks (like literal '%' in smb.conf)

David Collier-Brown davec-b at rogers.com
Wed May 9 13:22:38 GMT 2007


   Ok, Alison, want to propose a patch to Andrew?

   And I'll then resurrect my crosscheck project, then, for the Samba 4
timescale.

--dave

Andrew Bartlett wrote:
> On Tue, 2007-05-08 at 08:49 -0400, David Collier-Brown wrote:
> 
>>Alison Winters wrote:
>>
>>>Indeed.  This fix should be trivial (add an option to alloc_sub_basic to
>>>do something like realloc_string_sub(a_string, "%%", "%")).  But it's
>>>also silly that backslashes sometimes have meaning and other times do
>>>not (see
>>>http://lists.samba.org/archive/samba-technical/2007-May/053111.html).  I
>>>think Samba would gain a lot from an audit of what values are expected
>>>and legal for each smb.conf option.
>>
>>	I did one once upon a time, as part of a proposal to
>>	sanity-check shares for mutually contradictory options,
>>	but we never went anywhere with it.
> 
> 
> Yeah, the problem there was that in the Samba world of insanely
> configurable options, the mutually contradictory options sometimes made
> sense...
> 
> A few years older and wiser, and I think reducing the number of valid
> (or at least unwarned) combinations (even at the expense of some
> historical configurations) would be a good thing...
> 
> 
>>	I wonder... there are a lot of little "kernel janitor"
>>	tasks that new contributors or very occasional contributors
>>	like myself might do, but we lack a "supervisor of
>>	cleaning staff" to review and apply proposed changes.
>>
>>	Are any of the core developers interested in the care
>>	and feeding of minor contributors? Of Google summer
>>	students?
> 
> 
> A number of us have been mentors for SoC in the past, and are again with
> our 2 students this year.  
> 
> For Samba4, I'm happy to try and help minor contributions and
> contributors along their way. 
> 
> Andrew Bartlett

-- 
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
davecb at spamcop.net           |                      -- Mark Twain
(416) 223-5943


More information about the samba-technical mailing list