svn commit: samba r22743 - in branches/SAMBA_4_0/source/lib/charset: .

[simo]

On Mon, 2007-05-07 at 16:51 +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> simo schrieb:
> > talloc_set_name_const() must be used _only_ with real const values as
> > the name suggests. And copying the value would be a waste of memory and
> > will get outdated after further manipulation.
> 
> Hi Simo,
> 
> you mix 'const' and 'static const' here.
> 
> and all other functions in lib/talloc/ do the same
> and also take care that tc->name always points to a valid string.

Ok we sorted this on IRC, I don;t like this too much, but I am glad we
cope with this. (And we found that talloc_append_string() was not
conforming so that is good :-)

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org