initial test version of CTDB clustered Samba available

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri May 4 06:03:24 GMT 2007

On Fri, May 04, 2007 at 07:59:28AM +0200, Volker Lendecke wrote:
> Why did you remove the "return False;" after the first
> sys_read()? Now we do two reads when select indicated
> readability. Sure, it is very unlikely we block for a long
> time there, but the idea was that this routine would not
> block.

Just found a real bug: The while loop in line 1600 expects
the data portion of the message to come in one sys_read
call, ctdbd_socket_readable returns False if the second
sys_read does not return the full message. I could imagine
that for large records and under high load this is not
always the case.

Do you want me to fix it?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list