[Fwd: DO NOT REPLY [Bug 3974] smbclient tar creating option arguments are confused with password provided in command line]

[simo]

Can someone with a better popt expertise than me try out the patch I
attached here (bug 3974) and see if it make sense?

For me it fixes the problem. The current code was working only because
of a mistake in popt usage when -T was in use (potGetOptArg was used in
a loop instead of the correct poptGetArg), thus leaving the argv[0] and
the argv[1] on the popt stack and not eating them by mistake.

But to fix the -T option way of eating arguments I have to munge and
save the service and eventually password option before they are grabbed
by the -T option code.

The patch looks ugly but works.

Simo.

-------- Forwarded Message --------
From: samba-bugs at samba.org
To: idra at samba.org
Subject: DO NOT REPLY [Bug 3974] smbclient tar creating option arguments
are confused with password provided in command line
Date: Mon, 26 Mar 2007 15:11:08 -0500 (CDT)

https://bugzilla.samba.org/show_bug.cgi?id=3974


idra at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|samba-bugs at samba.org        |idra at samba.org
             Status|NEW                         |ASSIGNED




------- Comment #1 from idra at samba.org  2007-03-26 15:11 MST -------
Created an attachment (id=2346)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2346&action=view)
try to fix clash between tar option parsing and reading service/password from
the command line

Can you try this patch?

This should solve the problem with the brain damaged way tar options are
parsed.


-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org