rename vfs_preallocate to vfs_preallocate_xfs

Bjoern Jacke bjoern at j3e.de
Thu Mar 22 14:28:55 GMT 2007


On Thu, Mar 22, 2007 at 07:22:10AM -0700, James Peach wrote:
> On 22/03/2007, at 5:29 AM, Bjoern Jacke wrote:
> 
> >Hi,
> >
> >as Linux is about to get a generic preallocate I would suggest to  
> >rename
> >the vfs_preallocate to vfs_preallocate_xfs to point out that this  
> >is the
> >xfs-only preallocate module. James and all, what do you think?
> 
> Why don't you just add the generic preallocation path to it?

it is not yet available and will only work with future kernels. In
addition to that - isn't the move of stuff like that into the vfs layer
done to be able to switch between different implementations (for example
generic posix acls and nfs4 acls ...). With the same argument I would
like to be able to let users decide which preallocation method to use:
the XFS ioctl or the future generic one.

Cheers
Björn


More information about the samba-technical mailing list