svn commit: samba r21736 - in branches/SAMBA_4_0: source/auth/credentials source/lib/ldb/common testprogs/blackbox

simo idra at samba.org
Sat Mar 10 15:14:17 GMT 2007


On Sat, 2007-03-10 at 15:43 +0100, Jelmer Vernooij wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> simo wrote:

> > I have to recheck the code, I remember we didn't put the init code in
> > ldb.c for a reason, but I forgot the reason :-)
> > It may even be that the original reason is not true anymore, but that
> > have to be assessed before doing the change.
> IIRC the reason was thread safety. The init code makes use of static
> variables. Calling ldb_connect() from two separate threads can  cause
> weird issues if it calls out to the init code.
> 
> The idea is that the init code gets called before any sort of threading
> is being used.

Thanks Jelmer, this was indeed the reason.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list