svn commit: samba r21736 - in branches/SAMBA_4_0: source/auth/credentials source/lib/ldb/common testprogs/blackbox

[simo]

On Wed, 2007-03-07 at 04:20 +0000, abartlet at samba.org wrote:
> Author: abartlet
> Date: 2007-03-07 04:20:10 +0000 (Wed, 07 Mar 2007)
> New Revision: 21736
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21736
> 
> Log:
> Fix the smbclient test to do something more interesting with the last
> few authentication tests.  Now that the tests correctly 'fail', I was
> able to fix the credentials subsystem to honour USER and PASSWD.
> 
> To get --machine-pass working, I needed ldb to always load it's static
> modules, so I put this in ldb_connect().

[..]

> Modified: branches/SAMBA_4_0/source/lib/ldb/common/ldb.c
> ===================================================================
> --- branches/SAMBA_4_0/source/lib/ldb/common/ldb.c	2007-03-07 03:10:30 UTC (rev 21735)
> +++ branches/SAMBA_4_0/source/lib/ldb/common/ldb.c	2007-03-07 04:20:10 UTC (rev 21736)
> @@ -232,6 +232,9 @@
>  {
>  	int ret;
>  
> +	/* We seem to need to do this here, or else some utilities don't get ldb backends */
> +	ldb_global_init();
> +
>  	ldb->flags = flags;
>  
>  	ret = ldb_connect_backend(ldb, url, options, &ldb->modules);
> 

Andrew I think this is wrong, can you revert?
the init must be done in the client application, it is how it has been
architected, moving it into ldb.c is not the right thing to do.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org