svn commit: samba r23597 - in branches/SAMBA_3_0/source/script: .

[Volker Lendecke]

On Mon, Jun 25, 2007 at 11:02:02AM -0500, Gerald (Jerry) Carter wrote:
> > I always found annoying to be cramped in 80 columns 
> > when my terminals are usually between 130 and 200 chars
> > wide, but if we make it a policy to be so constrained
> > then so be it.
> 
> I'm really just raising the discussion.   I think we just
> need agreement.  We have too much code reformatting (based
> on personal preference) in our patches.   There's been a
> loose agreement on formatting in the past and I've never
> been a big fan of Coding Style rules.  But as we try to
> expand the developer pool, an unspoken agreement is insufficient.

I know that I'm guilty of reformatting patches, but lately
I've tried to only reformat stuff that I touch anyway.

Is there a technical way to limit only new code to 80
columns?

My main reason for the 80 colums is not that I can not
afford a large screen, it is that it makes it hard to write
deeply nested control structures. More than 2 levels at most
is confusing 99% of the time. There definitely are necessary
exceptions (I'm deep in open_file_ntcreate() again), but
these should be avoid even at very high cost.

Just my 2 cents,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070625/a9829557/attachment.bin