sloppy code formatting?

Gerald (Jerry) Carter jerry at samba.org
Mon Jun 25 15:26:31 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Folks,

While considering how a distributed SCM might work for us,
I've come across the need to potentially codify some formatting
rules to reduce on unnecessary diffs.  Two things that have come
up are

* The 80 column boundary.

  $ find . -name "*.[ch]" -print | wc -l
  995
  $ find . -name "*.[ch]" -exec script/count_80_col.pl {} \; | wc -l
  718

* Trailing whitespace:

  $ find . -name "*.[ch]" -exec script/strip_trail_ws.pl {} \;
  $ svn diff | wc -l
  221187

Note that I haven't filtered out the autogenerated code
(which I should).

Getting to any coding style standard is hard.  I've added a
copy of the Linux kernel Lindent script (script/format_indent.sh).
I not proposing anything right now.  Just pointing out
what I think is a problem as we attempt to grow the number
of developers working on Samba.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGf96nIR7qMdg1EfYRAul2AKDY3YjWBaLnUrS2h5DAddIDFNGLqQCfcSYA
PoL19IEAMsWF1GuOTLDYauI=
=DmLA
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list