rename_internals and rename_internals_fsp consolidated

[Jeremy Allison]

On Fri, Jun 15, 2007 at 12:07:51AM +0200, Volker Lendecke wrote:
> 
> Attached find a patch with lots of "-" inside: It changes
> rename_internals to open the file and then calls
> rename_internals_fsp. This then does not open the file a
> second time via can_delete, we already checked the share
> modes in the first open.
> 
> It does not survive the wildcard part of RAW-RENAME yet and
> something in RAW-NOTIFY is broken, but I think that can be
> fixed.
> 
> This is done with the same intention in mind I had with
> consolidating the unlink calls a bit, code simplification
> and reducing races.
> 
> What do you think, assuming I can fix it to pass the torture
> tests?

I *really* like patches with lots of '-' :-) :-).

If you can make it pass the torture tests I'd be
really happy to review it and let's get it in !

Jeremy.