[PATCH] Expanding nested groups in winbindd_getgrnam()

Jeremy Allison jra at samba.org
Wed Jun 13 17:51:07 GMT 2007


On Wed, Jun 13, 2007 at 12:22:01AM -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Here's a rough patch for expanding domain group membership
> in the winbindd_getgrnam() call.  Couple of comments:
> 
> * Adds "winbind expand groups" parameter which defines the
>   max depth winbindd will expand group members.  The default
>   is the current behavior of one level of expansion.
> * The entire getrgnam() interface should be async.  I
>   haven't done that.
> * Refactors the domain users hack in fill)grent_mem() into
>   its own function.
> 
> Comments?  I'd like to check this in for 3.0.26 as a
> preliminary implementation for people that need it.

Looks clearer code to me. +1.

Jeremy.


More information about the samba-technical mailing list