[PATCH 1/4] Make sure groups[0] is the effective gid on FreeBSD.

[Jeremy Allison]

On Thu, Jun 07, 2007 at 08:35:29PM -0700, James Peach wrote:
> On BSD systems, the first gid passed to setgroups(2) should be the  
> effective
> gid. Make sure we grow the groups list when switching credentials to  
> guarantee
> this (as far as possible).

Sorry, I hate this and won't accept it.

I want to see the *BSD brokenness split out as
far as possible as a sepeate set of #ifdefs
from the working code so I can see *exactly*
what you're doing here.

This is changing too much in a critical codepath.

Also, your mailer has mangled it to 80 column
wrap, which makes this doubly unreadable.

Sorry, I'm voting -1 on this until I see a
clear explaination of the change.

Jeremy