svn commit: samba r23290 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

Jeremy Allison jra at samba.org
Sat Jun 2 04:58:13 GMT 2007


On Fri, Jun 01, 2007 at 10:02:30PM -0500, Gerald (Jerry) Carter wrote:
> 
> It's is better IMO to use the correct context pointer
> so that in this case you can free the array
> witout worrying about it the mem_ctx point is freed

I don't know what you mean by this. Actually, either
pointer works, it simply is a matter of taste.

> I think Michael's original code is correct.
> For example, this is how the struct samu* stuff
> is done.

Fair enough. We were discussing taste though
(which is why I prefered talloc_move rather
than talloc_steal :-).

> The moral of the story is "Don't mix malloc and
> talloc".

That's true enough :-)


More information about the samba-technical mailing list