patching Samba's nsswitch/pam_winbind.c

[Mikhail Teterin]

Hello!

The file compiles with a large number of warnings at the moment.
Many of them are 64bit-specific, but not all.

The attached patch fixes the following three problems:

	1. The pamh argument is not read-only -- at least, it is not on FreeBSD.
	2. The functions pam_get_data and pam_get_item are declared as:

     int
     pam_get_data(pam_handle_t *pamh, const char *module_data_name,
	 void **data);

	   and

     int
     pam_get_item(pam_handle_t *pamh, int item_type, const void **item);

	   Note, that there is not read-only guarantee in the case of data --
	   on FreeBSD. On Solaris-10 both the pamh and the data are, indeed,
	   const, and on Linux, probably, too.

	   This parts of the patch may be FreeBSD-specific, although our
	   pam(3) claims the following compliance:

	STANDARDS
	     X/Open Single Sign-On Service (XSSO) - Pluggable Authentication
	     Modules, June 1997.

	3. The correct way to print a pointer is using %p. The file
	   currently prints the pointer as a 32-bit integer...

Samba's bugzilla is down at the moment -- please, consider the patch (or
pieces of it) at your leisure.

Thanks! Yours,

	-mi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-nsswitch_pam_winbind.c
Type: text/x-patch
Size: 5771 bytes
Desc: ASCII C program text
Url : http://lists.samba.org/archive/samba-technical/attachments/20070601/933bafa0/patch-nsswitch_pam_winbind.bin