svn commit: samba r23856 - in branches: SAMBA_3_2/source/modules SAMBA_3_2_0/source/modules

[Jeremy Allison]

On Thu, Jul 12, 2007 at 12:09:33PM -0700, James Peach wrote:
> On Jul 12, 2007, at 11:49 AM, jra at samba.org wrote:
> 
> >Author: jra
> >Date: 2007-07-12 18:49:44 +0000 (Thu, 12 Jul 2007)
> >New Revision: 23856
> >
> >WebSVN: 
> >http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23856
> >
> 
> [snip]
> 
> >+/* != 0 if this module will be compiled as static */
> >+
> >+#define STATIC 0
> >+
> >+#if STATIC
> >NTSTATUS vfs_zfsacl_init(void);
> >-NTSTATUS vfs_zfsacl_init(void)
> >+#else
> >+NTSTATUS init_module(void);
> >+#endif
> >+
> >+NTSTATUS
> >+#if STATIC
> >+	vfs_zfsacl_init
> >+#else
> >+	init_module
> >+#endif
> >+		(void)
> 
> What's this hunk all about? The build system already takes care of  
> #defining the module init function appropriately depending on whether  
> the user chose static or dynamic at configure time. This hardcodes  
> static.

Dunno - I just added that from their patch. I'm trusting them
to maintain ZFS stuff. Jiri - do you have any comments ?

James, feel free to fix it.

Jeremy