unix_convert() without pstrings

Jeremy Allison jra at samba.org
Sun Jul 8 18:08:39 GMT 2007

On Sun, Jul 08, 2007 at 07:09:13PM +0200, Volker Lendecke wrote:
> Hi, Jeremy!
> This patch took my weekend, this is scary stuff. At least for
> me. Just to sweeten you Sunday a bit :-)
> Attached find a patch that removes the pstring assumption
> from the core of unix_convert. It only assumes pstrings on
> entry and exit for compatibility with the callers, but this
> can be easily removed now.
> Under http://samba.org/~vlendec/unix_convert/ you find the
> list of checkins that led to this patch, as a whole it is
> definitely not understandable. The core begins with patch
> number 0008. I also uploaded my current version of
> filename.c and statcache.c.

Thanks for that - I'll go over this monday. At first
glance (and I mean glance :-) looks really good.



More information about the samba-technical mailing list