svn commit: samba r23726 - in branches/SAMBA_3_0/source: include lib libsmb smbd

[Volker Lendecke]

On Fri, Jul 06, 2007 at 03:58:18PM -0700, Jeremy Allison wrote:
> > Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
> > checkin will pull this up to srvstr_get_path. At that point we can get more
> > independent of the inbuf, the base_ptr in pull_string will only be used
> > to satisfy UCS2 alignment constraints.
> 
> +1 from me. I might go and add some local variable optimizations
> as I hate to see the same macro call made over and over again on
> subsequent lines of code :-).

This is what the smb_request is for. I looked at putting
that into all path handlers just for this reason, but then I
got distracted by statcache.c :-)

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070707/161fa85b/attachment.bin