Add "struct smb_request"

Gerald (Jerry) Carter jerry at samba.org
Thu Jul 5 15:49:13 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> Hi!
> 
> Attached find a patch that reduces access to the global
> inbuf a tiny bit. It adds a struct smb_request that contains
> some of the fields from the SMB header, removing the need to
> access inbuf directly. This right now is used only in the
> open file code & friends, and creating that header is only
> done when needed. This needs more work, but it is a start.
> 
> The second patch builds upon this and removes
> get_current_mid(), another function that accesses the global
> inbuf.

It seems reasonable to me.  +1 from me.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGjRL4IR7qMdg1EfYRAtBtAJwM6jiJnFm0tJjSgSRnFJR8ToqG1ACg7Eit
h7DE18N4QxfyFcuTUBT8wio=
=ROkd
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list