svn commit: samba r23691 - in branches: SAMBA_3_0/source/modules SAMBA_3_0_26/source/modules

Jeremy Allison jra at samba.org
Tue Jul 3 23:44:05 GMT 2007


On Tue, Jul 03, 2007 at 11:34:02PM +0000, idra at samba.org wrote:
> Author: idra
> Date: 2007-07-03 23:34:01 +0000 (Tue, 03 Jul 2007)
> New Revision: 23691
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23691
> 
> Log:
> 
> fix for bug on touching files as described here:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243897

Arg. Just a style thing but can you change the
variable name "status" to "ret".

Historically we use "status" for NTSTATUS
and "ret" for an int.

It;s just convention but it makes code easier
to read.

Jeremy.


More information about the samba-technical mailing list