svn commit: samba r23689 - in branches/SAMBA_3_0/source: . exports

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Peach wrote:
> On Jul 3, 2007, at 1:07 PM, Gerald (Jerry) Carter wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> James Peach wrote:
>>
>>>> +SHLD_DSO = $(SHLD) $(LDSHFLAGS) $(DSO_EXPORTS)
>>>
>>> You should be able to make this
>>>
>>> SHLD_DSO = $(SHLD) $(LDSHFLAGS) $(LDFLAGS) $(DSO_EXPORTS) -o $@
>>
>> I know.  It was just personal preference to leave the -o
>> option in the target line.  I don't know why except it
>> made the line read better to me.  But if you or someone
>> else feel strongly about it, I'll defer.
> 
> I don't exactly feel strongly about it. I have a 
> general policy that Makefile rules should not contain
> duplicate information unless they have to

"He who cares the most, wins" and I don't care so you win :-)
I'll make the change in the next go round.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGiq+qIR7qMdg1EfYRApzwAKDfl2oKaApcDbmaxxchbaBE5X39JQCffbkE
qutYdfsCbF0fgjMRy5Ruk94=
=YjL+
-----END PGP SIGNATURE-----