Vista and setting printer ACLs

[Jeremy Allison]

On Wed, Jan 31, 2007 at 01:50:03PM +0100, Martin Zielinski wrote:
> Too hasty ;-/
> 
> --- samba-3.0.23d.orig/source/rpc_parse/parse_spoolss.c 2006-06-23 
> 15:16:52.000000000 +0200
> +++ samba-3.0.23d/source/rpc_parse/parse_spoolss.c      2007-01-31 
> 13:49:02.000000000 +0100
> @@ -3897,7 +3897,7 @@
>                         break;
>                 }
>         }
> -       if (ptr_sec_desc)
> +       if (q_u->level == 3 || ptr_sec_desc)
>         {
>                 if (!sec_io_desc_buf(desc, &q_u->secdesc_ctr, ps, depth))
>                         return False;

Can you send me an ethereal capture trace of this please ?
Is Vista really sending a NULL SD here ?
I'm not sure this is the correct fix. Wouldn't the attached
patch work better ?

Jeremy
-------------- next part --------------
Index: rpc_server/srv_spoolss_nt.c
===================================================================
--- rpc_server/srv_spoolss_nt.c	(revision 21064)
+++ rpc_server/srv_spoolss_nt.c	(working copy)
@@ -6346,6 +6346,9 @@
 				result = update_printer_sec(handle, level, info, p, secdesc_ctr);
 			return result;
 		case 3:
+			if (!secdesc_ctr) {
+				return WERR_OK;
+			}
 			return update_printer_sec(handle, level, info, p,
 						  secdesc_ctr);
 		case 7: