[PATCH] decouple RPC modules from get_pipe_fns()

[Jelmer Vernooij]

On Fri, Jan 26, 2007 at 02:05:54PM -0800, James Peach wrote:
> On 26/01/2007, at 1:47 AM, Volker Lendecke wrote:
> >On Thu, Jan 25, 2007 at 11:32:33PM -0800, James Peach wrote:
> >>-        rpc_entry->cmds = SMB_REALLOC_ARRAY(rpc_entry->cmds,  
> >>struct api_struct, rpc_entry->n_cmds + size);
> >>+        rpc_entry->cmds = SMB_REALLOC_ARRAY(rpc_entry->cmds,
> >>+			    struct api_struct, rpc_entry->n_cmds + ncmds);
> >> 	if (!rpc_entry->cmds) {
> >> 		return NT_STATUS_NO_MEMORY;
> >> 	}
> >>-        memcpy(rpc_entry->cmds + rpc_entry->n_cmds, cmds, size *  
> >>sizeof(struct api_struct));
> >>-        rpc_entry->n_cmds += size;
> >>+        memcpy(rpc_entry->cmds + rpc_entry->n_cmds, cmds,
> >>+		ncmds * sizeof(struct api_struct));
> >>+        rpc_entry->n_cmds += ncmds;

> >I know it's in the tree right now, but while changing this
> >-- I don't see why this REALLOC/memcpy is necessary. Maybe
> >we can get rid of it and point to the tables directly?

> Yep, I'll be doing that next.

> BTW, this patch is against 3.0.24. Volker, does the winreg pipe  
> intentionally diverge between SAMBA_3_0 and SAMBA_3_0_24?
Yes, we're working on autogenerating the winreg pipe marshalling code
using pidl (from Samba4). AFAIK that code wasn't sufficiently stable when
SAMBA_3_0_24 was created. 

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20070127/2f34d66d/attachment.bin