[SAMBA3][PATCH] Use more talloc in auth

Jeremy Allison jra at samba.org
Mon Jan 22 17:00:34 GMT 2007

On Tue, Jan 23, 2007 at 12:09:02AM +1100, Andrew Bartlett wrote:
> This patch derives from debian bug 407517, where Jamie is seeing smbd
> memory use skyrocket, when used from IIS.
> I'm concerned about two things: memory leaks of server_info in closed
> sessions (and leaks of other attached things), and the specific
> behaviour of the getpwnam() cache.
> I've adjusted the cache to use talloc_unlink(), which I think gives more
> exact semantics for what is wanted here.  An in the auth code, I've
> tried to start using the new talloc(), to ensure we can't loose memory.
> This passes the 'make test' of Samba3.  I don't know if it solves
> Jamie's problem however.  (I just took a pot shot at some likely
> suspects).
> Thoughts?

Don't like the use of talloc_steal without explicit comments
in the code saying what is being moved around and why please...


More information about the samba-technical mailing list