svn commit: samba r20883 - in branches: SAMBA_3_0/source/include SAMBA_3_0/source/libsmb SAMBA_3_0/source/locking SAMBA_3_0/source/smbd SAMBA_3_0_24/source/include SAMBA_3_0_24/source/libsmb SAMBA_3_0_24/source/locking SAMBA_3_0_24/source/smbd

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jan 19 07:35:42 GMT 2007

On Thu, Jan 18, 2007 at 05:43:37PM -0800, Jeremy Allison wrote:
> Now - I wonder what cost this has in production ? :-).

For get_delete_on_close_flag() we don't need to go through
the whole get_share_mode_lock() thing, a special routine
just doing the tdb_read without an app-level lock is
sufficient. And this I think should not hurt too badly.

tdb still does the lower-level locking, and it also does the
malloc. One of tridge's plans always was to have a
tdb_fetch_locked_ro() (or something similar) that does not
do the malloc and provides direct access to the mmap region.

This should be sufficiently fast then I think.

> PS. I know I'm polishing the underside of the table,
> I just can't help myself :-) :-).

I know, this can become addictive. :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list