r18191 -- Run all events that are pending

Jeremy Allison jra at samba.org
Wed Jan 17 17:03:32 GMT 2007

On Wed, Jan 17, 2007 at 10:02:21AM +0100, Volker Lendecke wrote:
> On Tue, Jan 16, 2007 at 09:37:38AM -0800, Jeremy Allison wrote:
> > > What particular situation did you fix with this? I'm asking
> > > because while running an event we might change the socket
> > > status and we might have to re-run select/epoll/whatever
> > > again.
> > 
> > There can be multiple events ready to run at a particular
> > time (krb5 refresh etc. events in winbindd) so we must run all
> > events whose time has come (so to speak :-).
> Sure. But this is "only" an optimization? We would end up in
> that loop next round anyway. Or does it fix a real bug?

It's not an optimization (at least in current code). I
recall missing events due to the select timeout not being
recalculated correctly. If you fix that then it becomes
an optimization.


More information about the samba-technical mailing list