svn commit: samba r20655 - in branches/SAMBA_3_0_24/source: client include libsmb printing rpc_server smbd

[James Peach]

On Jan 10, 2007, at 11:15 AM, Jeremy Allison wrote:

> On Wed, Jan 10, 2007 at 10:59:35AM -0800, James Peach wrote:
>>>   branches/SAMBA_3_0_24/source/client/client.c
>>>   branches/SAMBA_3_0_24/source/include/smb.h
>>>   branches/SAMBA_3_0_24/source/include/smb_macros.h
>>
>> ISDOT and ISDOTDOT are already defined in lib/replace/system/dir.h.  
>> Do
>> you really need them here?
>
> They were already in smbd/dir.c

Yeh, I put them there in the pre-libreplace days.

>
>> Do you really mean "if (ISDOT(start))"? If ISDOT(start) is true, then
>> end is guaranteed to be '\0'.
>
> Yes I think so

'k

--
James Peach | jpeach at samba.org