svn commit: samba r20655 - in branches/SAMBA_3_0_24/source: client include libsmb printing rpc_server smbd

[James Peach]

On Jan 10, 2007, at 9:47 AM, jra at samba.org wrote:

> Author: jra
> Date: 2007-01-10 17:47:53 +0000 (Wed, 10 Jan 2007)
> New Revision: 20655
>
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20655
>
> Log:
> After consulting with Volker, fix our pathname
> handling. Gets rid of more code than it adds.
> I will port this to SAMBA_3_0 next. There are
> still some wrinkles with wildcard delete I am
> working on - for example a dirtype pattern of
> 0x8aa4 isn't handled correctly yet.... still
> looking at this.
> Jeremy.
>
> Modified:
>    branches/SAMBA_3_0_24/source/client/client.c
>    branches/SAMBA_3_0_24/source/include/smb.h
>    branches/SAMBA_3_0_24/source/include/smb_macros.h

ISDOT and ISDOTDOT are already defined in lib/replace/system/dir.h. Do  
you really need them here?

>    branches/SAMBA_3_0_24/source/libsmb/clifile.c
>    branches/SAMBA_3_0_24/source/libsmb/errormap.c
>    branches/SAMBA_3_0_24/source/printing/nt_printing.c
>    branches/SAMBA_3_0_24/source/rpc_server/srv_srvsvc_nt.c
>    branches/SAMBA_3_0_24/source/smbd/dosmode.c
>    branches/SAMBA_3_0_24/source/smbd/filename.c

Do you really mean "if (ISDOT(start))"? If ISDOT(start) is true, then  
end is guaranteed to be '\0'.

--
James Peach | jpeach at samba.org