svn commit: samba r20570 - in branches/SAMBA_4_0/source/libnet: .

Andrew Bartlett abartlet at
Fri Jan 5 22:12:45 GMT 2007

On Fri, 2007-01-05 at 21:22 +0000, metze at wrote:
> Author: metze
> Date: 2007-01-05 21:22:15 +0000 (Fri, 05 Jan 2007)
> New Revision: 20570
> WebSVN:
> Log:
> use talloc_asprintf() instead of talloc_asprintf_append()
> because talloc_asprintf_append() doesn't work like talloc_append_string()
> which uses strlen() on the old string instead of (tc->size - 1)
> This matter in this case because strlower_talloc() over allocates
> tridge: how should we fix this in lib/talloc/?

I can't imagine anyone who expects this behaviour:  The extra strlen()
is a small price to pay for sanity.  You are not meant to know that
talloc() has magic internal state...

Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 
Samba Developer, Red Hat Inc.        
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list