(no subject)

tridge at samba.org tridge at samba.org
Fri Jan 5 03:38:27 GMT 2007


Jelmer,

 > #ifndef HAVE_UINT_ENUMS
 > #define STYPE_HIDDEN    ( 0x80000000 )
 > ...
 > #else
 > #define STYPE_HIDDEN	-1
 > #endif

except that the value is wrong (0x80000000 is not -1).

What if we generated this:

#define STYPE_HIDDEN (ENUM_CAST)(0x80000000)

and defined ENUM_CAST and had this in includes.h:

#ifdef HAVE_UINT_ENUMS
#define ENUM_CAST unsigned int
#else
#define ENUM_CAST int
#endif

that means less cruft in the generated headers, plus no special code
in pidl.

Cheers, Tridge

PS: I haven't tested the above ...


More information about the samba-technical mailing list