BUG in enumprintprocdatatypes
Jeremy Allison
jra at samba.org
Tue Feb 27 22:04:39 GMT 2007
On Tue, Feb 27, 2007 at 08:46:58AM +0100, Martin Zielinski wrote:
>
>
> Gerald (Jerry) Carter schrieb:
> >-----BEGIN PGP SIGNED MESSAGE-----
> >Hash: SHA1
> >
> >Martin Zielinski wrote:
> >>Hello!
> >>
> >>enumprintprocdatatypes_level_1() in rpc_server/srv_spoolss_nt.c allways
> >>returns WERR_NOMEM.
> >>
> >>I'd propose to initialize the result var with WERR_OK
> >>instead WERR_NOMEM.
> >
> >Shouldn't we always just return "RAW" ?
> >
> That would be fine :-)
> It's just a coding error. "result" is initialized with WERR_NOMEM and
> never changed to a "NO_ERROR" value. So the returned RPC status is "NOMEM".
> look (i removed the empty lines):
I just fixed this in svn.
Thanks !
Jeremy.
More information about the samba-technical
mailing list