Managing DNs in libads only in utf8

simo idra at samba.org
Tue Feb 27 17:58:28 GMT 2007


On Tue, 2007-02-27 at 09:39 -0800, Jeremy Allison wrote:
> On Tue, Feb 27, 2007 at 11:16:59AM -0500, simo wrote:
> > 
> > Man, do anybody read mails? Or do you all just read the first 10 lines?
> > 
> > This was in my first mail:
> >         This affects primarily lookup_usergroups_member()*** and
> >         lookup_usergroups_memberof() in nsswitch/winbindd_ads.c as they
> >         need an intact DN.
> > 
> > Seem nobody cared to read that mail, and jumped on the first 10 lines
> > jra highlighted. ... Uhm I'll blame Jeremy :-)
> 
> The small patch (5 or so lines) I created I think fixes the
> issue that the submtter reported.
> 
> I do *not* want your fix in 3.0.25 please. I still
> don't believe it's thought though enough. I know
> you can construct a case where it fails if you
> set the unix charset differently, what I have
> not yet seen is a report from an actual *user*
> experiencing the problem, and a reason why
> they can't just shift their unix charset to
> utf8.
> 
> I think this patch introduces far more complexities
> than it fixes, and I vote -1 on it.

I'll try to stay calm, and ask you politely to read the whole thread
before commenting on random pieces of it :)

Also, what 5 lines patch?

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list