Managing DNs in libads only in utf8
idra at samba.org
Tue Feb 27 14:33:39 GMT 2007
On Tue, 2007-02-27 at 15:29 +0100, Volker Lendecke wrote:
> On Tue, Feb 27, 2007 at 09:21:25AM -0500, simo wrote:
> > I can certainly make it in a bzr tree if people prefer I do it this way.
> In your current patch proposal you for example have renamed
> a lot of variables. Separating those renames to checkins of
> their own would help review a lot.
I know, I did that (bind_path -> base_dn) to insure the compiler to barf
if I missed something and to make sure I already checked the function
while following dependencies, so, no, it would not have been a separate
commit anyway, it was not just a caprice, it was functional to my
keeping the code sane while changing it.
Of course I could sed/base_dn/bind_path/ back the diff but I usually
don't like to use sed on the code :-)
Samba Team GPL Compliance Officer
email: idra at samba.org
More information about the samba-technical